Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PM-12092] fix: Add new item should set item type #11049

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

[PM-12092] fix: Add new item should set item type #11049

wants to merge 5 commits into from
+1 −1

Conversation

Chandra-Mauli-Sharma
Copy link

🎟️ Tracking

Add new item should set item type (#10994)

📔 Objective

Selecting an item type to filter by and then clicking on + (Add new item) should set the item type of the new item.

📸 Screenshots

image
image

Recording.2024-09-15.021612.mp4

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@Chandra-Mauli-Sharma Chandra-Mauli-Sharma requested a review from a team as a code owner September 14, 2024 20:48
@bitwarden-bot
Copy link

Thank you for your contribution! We've added this to our internal Community PR board for review.
ID: PM-12092

@bitwarden-bot bitwarden-bot changed the title feat: Add new item should set item type [PM-12092] feat: Add new item should set item type Sep 14, 2024
@Chandra-Mauli-Sharma Chandra-Mauli-Sharma changed the title [PM-12092] feat: Add new item should set item type [PM-12092] fix: Add new item should set item type (bitwarden#10994) Sep 14, 2024
@Chandra-Mauli-Sharma Chandra-Mauli-Sharma changed the title [PM-12092] fix: Add new item should set item type (bitwarden#10994) [PM-12092] fix: Add new item should set item type Sep 14, 2024
@Chandra-Mauli-Sharma
Copy link
Author

Chandra-Mauli-Sharma commented Sep 14, 2024 •
edited
Loading

This PR fixes #10994

@djsmith85 djsmith85 linked an issue Sep 14, 2024 that may be closed by this pull request
Add new item should set item type #10994
Open
1 task
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ Chandra-Mauli-Sharma
❌ cd-bitwarden
You have signed the CLA already but the status is still pending? Let us recheck it.

1 similar comment
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ Chandra-Mauli-Sharma
❌ cd-bitwarden
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 17, 2024 •
edited
Loading

Logo
Checkmarx One – Scan Summary & Details – db08fd52-915e-4be3-a0c5-6ba24948cda7

Fixed Issues

Severity Issue Source File / Package
MEDIUM Client_Privacy_Violation /libs/tools/generator/components/src/credential-generator-history.component.html: 6
MEDIUM Client_Privacy_Violation /apps/web/src/app/tools/access-intelligence/password-health.component.html: 50
MEDIUM Client_Privacy_Violation /apps/web/src/app/tools/access-intelligence/password-health.component.html: 45
MEDIUM Client_Privacy_Violation /apps/web/src/app/tools/access-intelligence/password-health.component.html: 40
MEDIUM Client_Privacy_Violation /apps/web/src/app/tools/access-intelligence/password-health.component.html: 45
MEDIUM Client_Privacy_Violation /apps/web/src/app/tools/access-intelligence/password-health-members.component.html: 72
MEDIUM Client_Privacy_Violation /apps/web/src/app/tools/access-intelligence/password-health-members.component.html: 72
MEDIUM Client_Privacy_Violation /apps/web/src/app/tools/access-intelligence/password-health-members.component.html: 77
MEDIUM Client_Privacy_Violation /apps/web/src/app/tools/access-intelligence/password-health-members.component.html: 67
MEDIUM Client_Privacy_Violation /libs/tools/generator/components/src/username-generator.component.html: 3

@cd-bitwarden cd-bitwarden added the needs-qa Marks a PR as requiring QA approval label Oct 17, 2024
cd-bitwarden
cd-bitwarden approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@cd-bitwarden cd-bitwarden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've reviewed your change and tested things locally, everything looks great. Thank you so much for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cd-bitwarden cd-bitwarden cd-bitwarden approved these changes

@shane-melton shane-melton Awaiting requested review from shane-melton shane-melton is a code owner automatically assigned from bitwarden/team-vault-dev

Assignees
No one assigned
Labels
community-pr needs-qa Marks a PR as requiring QA approval
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add new item should set item type
4 participants
@Chandra-Mauli-Sharma @bitwarden-bot @CLAassistant @cd-bitwarden