You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Based on the items raised in the "general feedback" meeting with me and @abergs.
Suggestion 1: rename AddPasswordlessSdk() to AddPassworless(). The Identity integration should either provide its own overloads with the same name (ideal) or have a separate method, like AddPasswordlessIdentity() (less ideal).
Suggestion 2: AddPasswordlessSdk() should either be callable without arguments (in which case the ApiKey/ApiSecret are resolved from conventional environment variables), or the options => ... overload should throw an exception when those two values aren't provided.
The text was updated successfully, but these errors were encountered:
JIRA item: https://bitwarden.atlassian.net/browse/PAS-206
Based on the items raised in the "general feedback" meeting with me and @abergs.
Suggestion 1: rename
AddPasswordlessSdk()
toAddPassworless()
. The Identity integration should either provide its own overloads with the same name (ideal) or have a separate method, likeAddPasswordlessIdentity()
(less ideal).Suggestion 2:
AddPasswordlessSdk()
should either be callable without arguments (in which case theApiKey
/ApiSecret
are resolved from conventional environment variables), or theoptions => ...
overload should throw an exception when those two values aren't provided.The text was updated successfully, but these errors were encountered: