Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Range is set improperly for S3_copy_object_range. #102

Open
JustinKyleJames opened this issue Sep 22, 2020 · 0 comments · May be fixed by #107
Open

Range is set improperly for S3_copy_object_range. #102

JustinKyleJames opened this issue Sep 22, 2020 · 0 comments · May be fixed by #107

Comments

@JustinKyleJames
Copy link

Shouldn't the end range for the following be params->startByte + params->byteCount - 1?

I am getting an error because of an attempt to write one byte beyond the file.

libs3/src/request.c

Lines 404 to 406 in 287e4be

snprintf(byteRange, sizeof(byteRange), "bytes=%zd-%zd",
params->startByte, params->startByte + params->byteCount);
append_amz_header(values, 0, "x-amz-copy-source-range", byteRange);

@trel trel mentioned this issue Dec 8, 2020
Closed
2 tasks
trel pushed a commit to irods/libs3 that referenced this issue Dec 9, 2020
@JustinKyleJames @trel
Fixed range for S3_copy_object_range
9284758 
Fixes bji#102
@trel trel linked a pull request Dec 9, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed range for S3_copy_object_range irods/libs3
1 participant
@JustinKyleJames