Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax scikit-learn constraint to support all of major version 1 #26

Open
corneliusroemer opened this issue Jul 12, 2024 · 1 comment
Open

Comments

@corneliusroemer
Copy link

I noticed you constrain scikit-learn to sub-major version. Is there a pressing reason for this? If not, would be good to relax as any environment with pathogen-embed (e.g. nextstrain's conda-base) is otherwise constrained by pathogen-embed.

scikit-learn latest version is 1.5.1, whereas you pin <1.5

@huddlej
Copy link
Contributor

huddlej commented Jul 14, 2024

@corneliusroemer I haven't tested pathogen-embed with sklearn 1.5.* yet, since it was just released in May and I've been focused on revisions for the associated paper. The main reason I pinned <1.5 is that the scikit-learn release policy allows breaking changes on "minor" versions, according to the v1.0.0 release highlights:

This release does not include any breaking changes apart from the usual two-release deprecation cycle. For the future, we do our best to keep this pattern.

For example, a t-SNE keyword has a planned deprecation in version 1.7.

Given that release policy, I would rather opt into new versions of scikit-learn than allow them by default.

When I added pathogen-embed to the Nextstrain environments, that was the first time scikit-learn had been added as a Nextstrain dependency. If we find the pathogen-embed pinning restricts other future work, we could revisit my thinking above. Do you have a specific need for v1.5.* now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants