streamlit-keyup no longer renders with Streamlit 1.32.2

[nathancooperjones]

Streamlit 1.32.2 released on 3/14/24 and, with this release, a change was made such that streamlit-keyup no longer renders at all.

I'll attach screenshots below with what renders on my screen with a variety of recent Streamlit releases with the following dummy app code:

from st_keyup import st_keyup
import streamlit as st


st.write(st.__version__)

value = st_keyup(label='Enter a value')

st.write(value)

Streamlit 1.31.0:

Streamlit 1.32.0:

Streamlit 1.32.1:

Streamlit 1.32.2:

[msabramo]

I saw this too.

Great job tracking down which version caused the breakage!

I wonder if we can get even more info about the breakage by cloning Streamlit from git and using git bisect to find the exact commit that caused the breakage. That could be really helpful to @blackary in figuring out a fix.

[msabramo]

OK, I just did a git bisect and FWIW, it says that 8de20441339a0e5232b32d60b66f76f0bcb5ee0b is the Streamlit commit that broke things:

(.venv)
abramowi at Marcs-MBP-3 in ~/Code/OpenSource/streamlit (1.32.2.dev20240313~2)(bisect)
$ git bisect good
8de20441339a0e5232b32d60b66f76f0bcb5ee0b is the first bad commit
commit 8de20441339a0e5232b32d60b66f76f0bcb5ee0b
Author: Ken McGrady <[email protected]>
Date:   Wed Mar 13 19:10:09 2024 -0700

    Fix initial iframe height for custom component (#8290)

    ## Describe your changes

    In 1.32.0, we introduced some changes to custom components that rendered
    an iframe of a certain height instead of a default of 0. This change
    ensures that when the `frameHeight` is `undefined`, it will use 0.

    ## GitHub Issue Link (if applicable)
    Closes #8285

    ## Testing Plan

    - Added a test to make sure it's set (and the Skeleton appears and
    disappears)

    ---

    **Contribution License Agreement**

    By submitting this pull request you agree that all contributions to this
    project are made under the Apache 2.0 license.

 .../CustomComponent/ComponentInstance.test.tsx     | 85 ++++++++++++++++++++++
 .../widgets/CustomComponent/ComponentInstance.tsx  | 36 ++++-----
 2 files changed, 98 insertions(+), 23 deletions(-)

[msabramo]

See #37 for a possible fix, although I mostly just got lucky messing around and don't know if this is a proper fix.

[blackary]

Wow, @msabramo , thank you so much for tracking the issue down and adding a fix -- this is so helpful!

[msabramo]

Thank you, @blackary for sharing your work!