Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dot in default value lead to variable not replaced #48

Open
aldarund opened this issue May 6, 2018 · 3 comments
Open

Dot in default value lead to variable not replaced #48

aldarund opened this issue May 6, 2018 · 3 comments

Comments

@aldarund
Copy link

aldarund commented May 6, 2018

E.g.
domainName: ${opt:domainName, 'beta.blabla.net'}
This wont be replaced with beta.blabla.net due to regexp https://github.com/simlu/yaml-boost/blob/master/src/index.js#L16

@simlu
Copy link
Collaborator

simlu commented May 6, 2018

Thanks for reporting this! Would you be interested in doing a pr?

@aldarund
Copy link
Author

aldarund commented May 6, 2018

@simlu ye, why not, its pretty fast issue :)

Btw in docs i see -> Variable and File Resolution Works identical to how this is defined for serverless here.
But i dont see any code for for example resolving variable resolution for self like ${self:provider.stage} . Readme wrong ? :)

@simlu
Copy link
Collaborator

simlu commented May 6, 2018

That might still be missing (as is inline variable resolution I think). The problem is that one needs to handle recursion.

We are currently building a lot or projects based on this, so this is still wip. Let me open some tickets.

Edit: Note that there are also certain things we can't and don't want to resolve. So possibly it is not desirable to resolve "self". Should certainly clarify the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants