From fb6a4bbe5a9b7a0d4083d49111b15f9e6a36f06c Mon Sep 17 00:00:00 2001 From: Carlos Cabanero Date: Mon, 8 Apr 2024 11:48:03 -0400 Subject: [PATCH] SmartKeys with KB disabled - Showing SmartKeys with the hardware keyboard has been working in a non-consistent way since the last iOS. We are disabling it as we kinda have to decide between having the keyboard bar properly hidden completely or this. And the keys were not useful on iPad anyway. We will figure out a better way for iOS18. --- Blink/KBTracker.swift | 6 ++++-- Settings/Base.lproj/Settings.storyboard | 2 +- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/Blink/KBTracker.swift b/Blink/KBTracker.swift index 7e2d88eca..34ccfce73 100644 --- a/Blink/KBTracker.swift +++ b/Blink/KBTracker.swift @@ -139,7 +139,8 @@ class KBObserver: NSObject, UIInteraction { } class KBTracker: NSObject { - private(set) var hideSmartKeysWithHKB = !BKUserConfigurationManager.userSettingsValue(forKey: BKUserConfigShowSmartKeysWithXKeyBoard) + private(set) var hideSmartKeysWithHKB = true + //private(set) var hideSmartKeysWithHKB = !BKUserConfigurationManager.userSettingsValue(forKey: BKUserConfigShowSmartKeysWithXKeyBoard) @objc static let shared = KBTracker() @@ -229,7 +230,8 @@ class KBTracker: NSObject { } @objc private func _updateSettings() { - hideSmartKeysWithHKB = !BKUserConfigurationManager.userSettingsValue(forKey: BKUserConfigShowSmartKeysWithXKeyBoard) + hideSmartKeysWithHKB = true + //hideSmartKeysWithHKB = !BKUserConfigurationManager.userSettingsValue(forKey: BKUserConfigShowSmartKeysWithXKeyBoard) input?.sync(traits: kbTraits, device: kbDevice, hideSmartKeysWithHKB: hideSmartKeysWithHKB) } diff --git a/Settings/Base.lproj/Settings.storyboard b/Settings/Base.lproj/Settings.storyboard index 6971010f1..692f2a6d7 100644 --- a/Settings/Base.lproj/Settings.storyboard +++ b/Settings/Base.lproj/Settings.storyboard @@ -38,7 +38,7 @@ - +