Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI statuses still get intermingled with log output #4086

Open
matt2e opened this issue Jan 17, 2025 · 1 comment
Open

CLI statuses still get intermingled with log output #4086

matt2e opened this issue Jan 17, 2025 · 1 comment
Assignees
@stuartwdouglas

Comments

@matt2e
Copy link
Collaborator

matt2e commented Jan 17, 2025

Image

Running FTL with -race earlier this week did show race conditions in the code as some vars aren't protected from concurrent access in any way. The readout from race had pointed to multiple goroutines reading/writing totalStatusLines
@github-actions github-actions bot added the triage Issue needs triaging label Jan 17, 2025
@alecthomas alecthomas mentioned this issue Jan 17, 2025
Open
@stuartwdouglas stuartwdouglas self-assigned this Jan 20, 2025
@github-actions github-actions bot removed the triage Issue needs triaging label Jan 20, 2025
@stuartwdouglas
Copy link
Collaborator

I think the totalStatusLines thing is only on exit, #4109 should fix it, but it does not explain the intermingling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stuartwdouglas stuartwdouglas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stuartwdouglas @matt2e