-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v2.1 validation doesn't seem to be working correctly #21
Comments
Hi @akodate, Could you tell me which blockcerts-verifier version (or where on the web) did you try for verifying? I have seen that indeed it breaks on blockcerts.org, and I know this one is not up to date, but I am trying to scope the issue. My local version does not verify (unable to get issuer profile) the v2.1 example of this repo, but does not yield a js error either. If I try to access the issuer profile manually it indeed is not there: https://www.blockcerts.org/blockcerts_v2_alpha/samples/issuer_testnet.json.
Are you saying that you are having problems with other v2.1 certificates? or 2.0? or both? |
@lemoustachiste So far I'm only concerned about JS errors; no validation errors yet. I was hoping to use the validator to find out if and how my v2.0 Blockcerts are incompatible with v2.1 since I can't find information on how to issue v2.1 Blockcerts or what's different about them. |
I just checked the 2.1 example from this repo (sample_valid.json); it throws a JS error on my blockcerts-verifier. The biggest difference between the 2.0 and 2.1 example certificates seems to be the RecipientProfile structure. I don't have all of this figured out, but this hint seems like it could be very useful for tracking the problem down. |
Just one more thing: This looks like a useful hint as well. |
First, a quick fix: V2_1_SCHEMA_LOCAL_PATH points to v2.0, as shown here:
cert-schema/cert_schema/schema_validator.py
Line 12 in 30dbc38
However, this doesn't seem to solve the whole problem. Certificates I tested still seem to pass v2.1 validation only to cause the blockcerts-verifier verification dialog (with the checkmark) to throw an error and not display at all.
Let me know if I'm overlooking something here since I'm not familiar with v2.1 (haven't seen it in cert-tools etc.) and am issuing using the usual v2 tools.
The text was updated successfully, but these errors were encountered: