Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can you remove the compiler from test dependencies? #13

Open
danielo515 opened this issue Dec 23, 2022 · 1 comment · May be fixed by #14
Open

Can you remove the compiler from test dependencies? #13

danielo515 opened this issue Dec 23, 2022 · 1 comment · May be fixed by #14

Comments

@danielo515
Copy link

danielo515 commented Dec 23, 2022

Hello. Thank you for this nice rescript implementation of tests.

Would you mind removing the dependency on the compiler? It is making our compilation to fail:

https://github.com/bloodyowl/rescript-test/blob/be462e6f6f553407eee56ae9d1ab160af26ff536/package.json#LL23-L26C5

We get the following error when compiling fresh (CI):

Dependency on rescript-test
Different compiler version: clean current repo
File "bsconfig.json", line 1
Error: package rescript-js not found or built 

Not sure if the problem comes from rescript-js or from just rescript compiler. But the thing is that it fails because it cleans the repo.

Or do you have experience addressing this kind of issues? If so, I will be happy to know how.

@ozanmakes ozanmakes linked a pull request Dec 23, 2022 that will close this issue
@ozanmakes
Copy link

The error about "Different compiler version" was misleading, main issue is rescript-js not being installed after running yarn add rescript-test. I made a PR #14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants