From 7787ed05725fbd8c621a54282a42725231cb906d Mon Sep 17 00:00:00 2001 From: Chris Beard Date: Thu, 9 Jan 2025 10:22:00 -0500 Subject: [PATCH] Fix: bug in queue admin command validation Fuzz tests caught this; the `if` block is never being executed. Signed-off-by: Chris Beard --- src/groups/mqb/mqbcmd/mqbcmd_parseutil.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/groups/mqb/mqbcmd/mqbcmd_parseutil.cpp b/src/groups/mqb/mqbcmd/mqbcmd_parseutil.cpp index 236c4b4ea7..4d74825d38 100644 --- a/src/groups/mqb/mqbcmd/mqbcmd_parseutil.cpp +++ b/src/groups/mqb/mqbcmd/mqbcmd_parseutil.cpp @@ -442,7 +442,7 @@ int parseDomainQueue(DomainQueue* queue, const bslstl::StringRef subcommand = next(); - if (name.empty()) { + if (subcommand.empty()) { *error = "DOMAINS DOMAIN QUEUE command must have " "a subcommand, such as PURGE, INTERNALS, or LIST."; return -1; // RETURN