Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bounce_connection support to hasql snapshot test #4697

Merged
merged 2 commits into from
Sep 20, 2024

Conversation

RohanNankani
Copy link
Contributor

No description provided.

@morgando morgando linked an issue Sep 17, 2024 that may be closed by this pull request
@morgando
Copy link
Contributor

/runtests

Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 6/578 tests failed ⚠.

The first 10 failing tests are:
lostwrite [setup failure]
largecsc2 [setup failure]
analyze_exit_immediately
snap_ha_retry_newsi_generated
truncatesc
truncatesc_ufid_on_generated

RohanNankani and others added 2 commits September 19, 2024 14:41
Signed-off-by: Morgan Douglas <[email protected]>

Refactor

Signed-off-by: Morgan Douglas <[email protected]>

refactor

Signed-off-by: Morgan Douglas <[email protected]>

Add newsi test

Signed-off-by: Morgan Douglas <[email protected]>

Refactor

Signed-off-by: Morgan Douglas <[email protected]>

.

Signed-off-by: Morgan Douglas <[email protected]>
Signed-off-by: Rohan Nankani <[email protected]>
@morgando
Copy link
Contributor

mdouglas47 Sep 19 15:29:20 2024 in-comdb2db rohan/add-disconnect-hasql.R20240919.5

Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Smoke testing: Error ⚠.
Cbuild submission: Success ✓.
Regression testing: 11/578 tests failed ⚠.

The first 10 failing tests are:
unionpar_maxqueue [setup failure]
sc_inserts_logicalsc_generated [setup failure]
autoanalyze [setup failure]
basic_ssl_generated [setup failure]
verify_db_parallel_generated [setup failure]
sc_resume_logicalsc_generated
sc_transactional_rowlocks_generated
truncatesc
timepart_trunc
timepart_trunc_serialsc_generated

Copy link
Contributor

@morgando morgando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you Rohan 😄

@morgando morgando merged commit c82448a into bloomberg:main Sep 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(hasql): Support testing resumed snapshot consistency
3 participants