Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify encoding/decoding of HCI packets #22

Open
ConnorRigby opened this issue Aug 31, 2020 · 0 comments
Open

Simplify encoding/decoding of HCI packets #22

ConnorRigby opened this issue Aug 31, 2020 · 0 comments

Comments

@ConnorRigby
Copy link
Collaborator

#19 Started this, however i'm not 100% happy with it either.
All of the pattern matches are so incredibly simple that worrying about an entire system of macros seems unnecessary to me.

The way ACL is implemented seemed like a decent base, but implementing return parameters for the CommandComplete event kind of put a wrench in that plan. The ACL implementation also uses a nested data structure that isn't a perfect fit for HCI since it's always a flat data structure.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ConnorRigby