Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Python version has no upper bound #1003

Open
aiwalter opened this issue Feb 25, 2023 · 2 comments
Open

[BUG] Python version has no upper bound #1003

aiwalter opened this issue Feb 25, 2023 · 2 comments
Labels

Comments

@aiwalter
Copy link

The problem:
Could you pls add an upper bound to your config?

python_requires = >= 3.7

Otherwise users might run into unexpected exceptions when having a newer Python version. E.g. as happened in past with matrixprofile issue.

@nils-braun
Copy link
Collaborator

Thanks for raising an issue @aiwalter!
However, maybe I am not understanding your request correctly. The tsfresh code itself is compatible with py 3.11 (I can add an upper bound for 3.12 as I do not know what it will bring, but I am pretty sure it will also be compatible) - however its dependencies might not (but this should be fixed/pinned in the dependencies then).
Would you think it is good to set an upper bound to 3.11 because numba is currently not compatible with it? To me that sounds like hiding the problem from the user.
Sorry if I misunderstood your request!

@jcoffi
Copy link

jcoffi commented Dec 26, 2023

It's a best practice to set upper bounds to the latest version of dependencies a package has been tested to work with, not necessarily to any dependencies further upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants