Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(database): implement order-independent equality for Reverts #1827

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

feat(database): implement order-independent equality for Reverts #1827

wants to merge 7 commits into from

Conversation

hoank101
Copy link

@hoank101 hoank101 commented Oct 17, 2024 •
edited by Rjected
Loading

Fixes #1813

@hoank101
Copy link
Author

hi @Rjected please help me review it, thank!

@hoank101 hoank101 requested a review from rakita October 18, 2024 16:08
Rjected
Rjected requested changes Oct 18, 2024
View reviewed changes
crates/database/src/states/reverts.rs Outdated Show resolved Hide resolved
crates/database/src/states/reverts.rs Outdated Show resolved Hide resolved
crates/database/src/states/reverts.rs Outdated Show resolved Hide resolved
@hoank101 hoank101 requested a review from Rjected October 19, 2024 02:58
@hoank101
Copy link
Author

hi @Rjected @rakita please help me review, thank

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rakita rakita Awaiting requested review from rakita

@Rjected Rjected Awaiting requested review from Rjected

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Manually impl PartialEq for Reverts
3 participants
@hoank101 @Rjected @rakita