Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore unused srt streamid values #3701

Open
5 of 13 tasks
moschopsuk opened this issue Aug 27, 2024 · 1 comment · May be fixed by #4087
Open
5 of 13 tasks

Ignore unused srt streamid values #3701

moschopsuk opened this issue Aug 27, 2024 · 1 comment · May be fixed by #4087
Labels
bug Something isn't working srt

Comments

@moschopsuk
Copy link

moschopsuk commented Aug 27, 2024

Which version are you using?

v1.9.0

Which operating system are you using?

  • Linux amd64 standard
  • Linux amd64 Docker
  • Linux arm64 standard
  • Linux arm64 Docker
  • Linux arm7 standard
  • Linux arm7 Docker
  • Linux arm6 standard
  • Linux arm6 Docker
  • Windows amd64 standard
  • Windows amd64 Docker (WSL backend)
  • macOS amd64 standard
  • macOS amd64 Docker
  • Other (please describe)

Describe the issue

When using a hardware encoder such as the blackmagic web presenter HD is seems to cause mediamtx to reject the stream due to some extra streamid parameters being sent by the encoder. Note these can't be switched off/disabled and seem to the default behavior.

This is an example streamid being sent by the encoder:

#!::bmd_uuid=0e1df79f-77e6-465c-b099-29a616e964f7,bmd_name=rdt-wp-003,r=test3,m=publish

A temp work around is to comment out the return, this fixes the issue.
Perhaps it should warn that it is ignoring none useful streamid parameters?

streamid.go

			default:
				// return fmt.Errorf("unsupported key '%s'", key)
			}

Describe how to replicate the issue

  1. start the server
  2. publish a srt stream with the blackmagic web hd encoder.
  3. see the error in the console and the stream is rejected.

Did you attach the server logs?

2024/08/27 14:42:01 INF [SRT] [conn 10.0.30.9:49599] opened
2024/08/27 14:42:01 INF [SRT] [conn 10.0.30.9:49599] closed: invalid stream ID '#!::bmd_uuid=0e1df79f-77e6-465c-b099-29a616e964f7,bmd_name=rdt-wp-003,r=test3,m=publish': unsupported key 'bmd_uuid'
2024/08/27 14:42:02 INF [SRT] [conn 10.0.30.9:49599] opened
2024/08/27 14:42:02 INF [SRT] [conn 10.0.30.9:49599] closed: invalid stream ID '#!::bmd_uuid=0e1df79f-77e6-465c-b099-29a616e964f7,bmd_name=rdt-wp-003,r=test3,m=publish': unsupported key 'bmd_uuid'
2024/08/27 14:42:03 INF [SRT] [conn 10.0.30.9:49599] opened
2024/08/27 14:42:03 INF [SRT] [conn 10.0.30.9:49599] closed: invalid stream ID '#!::bmd_uuid=0e1df79f-77e6-465c-b099-29a616e964f7,bmd_name=rdt-wp-003,r=test3,m=publish': unsupported key 'bmd_uuid'
2024/08/27 14:42:04 INF [SRT] [conn 10.0.30.9:49599] opened
2024/08/27 14:42:04 INF [SRT] [conn 10.0.30.9:49599] closed: invalid stream ID '#!::bmd_uuid=0e1df79f-77e6-465c-b099-29a616e964f7,bmd_name=rdt-wp-003,r=test3,m=publish': unsupported key 'bmd_uuid'

yes

Did you attach a network dump?

no

Many Thanks!

@aler9
Copy link
Member

aler9 commented Dec 28, 2024

Thanks for reporting the issue, this is fixed by #4087

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working srt
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants
@moschopsuk @aler9 and others