Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dvl-a50: mavlink2resthelper: fix incorrect IDs #31

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ES-Alexander
Copy link
Contributor

@ES-Alexander ES-Alexander commented Aug 30, 2023

  • system_id set to match the vehicle ID, since they should be part of the same system
  • component_id set to 197 (MAV_COMP_ID_VISUAL_INERTIAL_ODOMETRY)
    • ⚠️ if this field is meant to specify the intended recipient then it should be 1 instead, since it should be sent to the autopilot, but if that's the case I'm not sure how or where we're supposed to set the source ID

Fixes #30

Untested, so probably good if someone can try it before it gets merged.

- `system_id` set to match the vehicle ID, since they should be part of the same system
- `component_id` set to 197 (`MAV_COMP_ID_VISUAL_INERTIAL_ODOMETRY`)
@clydemcqueen
Copy link
Contributor

@ES-Alexander I will work on testing this in-water over the next few weeks.

@ES-Alexander
Copy link
Contributor Author

@clydemcqueen did you ever get around to testing this? :-)

@clydemcqueen
Copy link
Contributor

@ES-Alexander Sadly, we did not. I'll see if I can schedule some test time w/ a DVL-rigged ROV.

@clydemcqueen
Copy link
Contributor

@ES-Alexander -- sorry, testing this (and PR 34) is just not making it to the top of the queue. We have limited time to run these sorts of tests on real hardware, and the test process is cumbersome (creating a docker image per PR, installing them, etc.)

Are there plans to create BETA and DEV tracks for extensions? We always run the latest ArduSub BETA on production dives (to get surftrak and other nifty features). I think it would be straightforward to switch to the BETA track of this extension, if such a thing existed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MAVLink msgs have sysid=255, compid=0; should be sysid=1, compid=?
2 participants