Fix cli on tests #102
Merged
Fix cli on tests #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickelectric
approved these changes
Nov 14, 2024
src/lib/cli.rs
Outdated
| #[instrument(level = "debug")] | ||
| pub fn log_path() -> String { | ||
| let log_path = | ||
| MANAGER.clap_matches.log_path.clone().expect( | ||
| MANAGER.get().unwrap().clap_matches.log_path.clone().expect( |
There was a problem hiding this comment.
can we have a macro to make the access easier ?
There was a problem hiding this comment.
I made it into a local function instead =)
joaoantoniocardoso
force-pushed
the
fix_cli_on_tests
branch
from
ded1f32 to
fd1b398
Compare
joaoantoniocardoso
force-pushed
the
fix_cli_on_tests
branch
from
fd1b398 to
fe7e1ee
Compare
patrickelectric
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow us to fix the test errors introduced by #101.
The problem happens when a test code calls any of the functions of the cli module, which then makes the
lazy_staticto createcli::Argsfrom the commandline of the binary being executed, conflicting with the test harness/setup.This change allows us to define the parsed
cli::Argsso that it won't conflict with the arguments being passed to the test harness/setup... yeah, this is a drawback of singletons using
lazy_static.