Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add password entropy requirements #2727

Open
pfrazee opened this issue Feb 1, 2024 · 5 comments · May be fixed by #2732
Open

Add password entropy requirements #2727

pfrazee opened this issue Feb 1, 2024 · 5 comments · May be fixed by #2732
Labels
improvement Not quite a feature but improves existing behavior

Comments

@pfrazee
Copy link
Collaborator

pfrazee commented Feb 1, 2024

The account creation flow needs to measure the entropy in a password and disallow overly simple passwords.

@pfrazee pfrazee added the improvement Not quite a feature but improves existing behavior label Feb 1, 2024
@mary-ext
Copy link
Contributor

mary-ext commented Feb 2, 2024

The most common library for this is zxcvbn by Dropbox, and there's an official JS port for it as well.
It seems like it's very large though, at 388.3 kB minzipped, so perhaps it might be best to lazily-load this?


Looking around, there's an alternative implementation named zxcvbn-ts and that might also be worth taking a look.

zxcvbn-ts seems to have the languages separate, it's 9 kB minzipped for the core library, and 225.9 kB + 551.9 kB for the common + English language set

@mary-ext mary-ext linked a pull request Feb 2, 2024 that will close this issue
@surfdude29
Copy link
Contributor

surfdude29 commented Feb 2, 2024

Looking around, there's an alternative implementation named zxcvbn-ts and that might also be worth taking a look.

Also, this comment details some key changes between zxcvbn and zxcvbn-ts.

And this is the demo page.

@mary-ext
Copy link
Contributor

mary-ext commented Feb 2, 2024

There's a simpler check if we skip dictionaries and assume that the user only makes use of the 93 characters that's on their keyboard, log2(93 ** length)

@surfdude29
Copy link
Contributor

Sorry for going a little off-topic: the serious data leakage incident at Spoutible which has been detailed today is a good reminder of how important it is to encourage users to create strong passwords when they sign up:

Troy Hunt: How Spoutible’s Leaky API Spurted out a Deluge of Personal Data

CE80264E-D876-4D94-A9F9-96CAC1A9E6A7

@deviantsemicolon
Copy link

https://xkcd.com/936

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Not quite a feature but improves existing behavior
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants