Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add h5py as a real dependency #510

Closed
stan-dot opened this issue Aug 7, 2024 · 1 comment · Fixed by #511
Closed

Add h5py as a real dependency #510

stan-dot opened this issue Aug 7, 2024 · 1 comment · Fixed by #511
Assignees
Labels
bug Something isn't working dependencies Pull requests that update a dependency file

Comments

@stan-dot
Copy link
Contributor

stan-dot commented Aug 7, 2024

 src/dodal/beamlines/i18.py:17: in <module>
    from dodal.devices.i18.sim_detector import SimDetector
/opt/hostedtoolcache/Python/3.10.14/x64/lib/python3.10/site-packages/dodal/devices/i18/sim_detector.py:2: in <module>
    from ophyd_async.sim import PatternGenerator
/opt/hostedtoolcache/Python/3.10.14/x64/lib/python3.10/site-packages/ophyd_async/sim/__init__.py:1: in <module>
    from .pattern_generator import PatternGenerator
/opt/hostedtoolcache/Python/3.10.14/x64/lib/python3.10/site-packages/ophyd_async/sim/pattern_generator.py:14: in <module>
    import h5py
E   ModuleNotFoundError: No module named 'h5py'
____________ ERROR collecting src/dodal/devices/i18/sim_detector.py ____________
ImportError while importing test module '/home/runner/work/dodal/dodal/src/dodal/devices/i18/sim_detector.py'.

that is because in ophyd-async h5py was added only as a dev dependency

Originally posted by @stan-dot in DiamondLightSource/dodal#722 (comment)

@stan-dot stan-dot added bug Something isn't working dependencies Pull requests that update a dependency file labels Aug 7, 2024
@stan-dot stan-dot self-assigned this Aug 7, 2024
@stan-dot
Copy link
Contributor Author

stan-dot commented Aug 7, 2024

spoke with @abbiemery about this , will try to fix fast

@stan-dot stan-dot linked a pull request Aug 7, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant