Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FastCS Eiger: Pass datatype from eiger to odin #529

Open
DominicOram opened this issue Aug 19, 2024 · 1 comment
Open

FastCS Eiger: Pass datatype from eiger to odin #529

DominicOram opened this issue Aug 19, 2024 · 1 comment

Comments

@DominicOram
Copy link
Contributor

Following #528 we should continue implementing the full functionality for the eiger that we need in MX. The datatype of data coming out of the eiger is dependant on the exposure time set on the detector. Odin needs to know the datatype up front so that it can correctly write data. During arm/open we need to get this out of the eiger and put it into odin. e.g. see https://github.com/DiamondLightSource/dodal/blob/46132f0e066debaf906c1a80dcefca175b3f5c01/src/dodal/devices/eiger.py#L320

Note that we need to do this after the exposure time has been accepted by the eiger as this is when it calculates the new bit depth

Acceptance Criteria

  • When the fastcs eiger is armed it correctly forwards the bit depth to odin
@DominicOram
Copy link
Contributor Author

@coretl is going to discuss with @GDYendell if we can do this in odin. Otherwise the plan would be to set exposure time and then datatype as the first thing in the plan for the detector (meaning that it won't be in parallel so we will have to see if this hurts performance)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant