-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move FastCS Eiger to fastcs
, move odin io/writer to seperate modules outside of eiger
#557
Comments
Despite doing the work I have no strong opinions on it's organisation. I defer to @coretl and @GDYendell who know more about the bigger picture than I do, I would just like to get a working |
In the |
I think this sounds reasonable. The repos are currently |
That probably makes sense... Then we have |
Looking at the recent fastcs eiger support, I noticed two things:
epics/eiger/_odin_io.py
- This appears to be general to allOdin
detectors, is that correct? If yes, I think it should be decoupled fromeiger
, maybe infastcs/odin/_odin_io.py
andfastcs/odin/_odin_hdf_writer.py
or something similar.Also, should the eiger support be moved under
fastcs
since it is a fastcs implementation? Then a separateADEiger
version could be placed underepics
.Thoughts?
The text was updated successfully, but these errors were encountered: