Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude rule that begins with /** takes very long #13

Open
DavidPerezIngeniero opened this issue Jan 29, 2015 · 4 comments
Open

Exclude rule that begins with /** takes very long #13

DavidPerezIngeniero opened this issue Jan 29, 2015 · 4 comments

Comments

@DavidPerezIngeniero
Copy link

If I write this, it takes too long:

fileset:
  includes: $dirWebapp/**
  excludes: /**/*.py
  targetDir: $INSTALL_PATH/webIma

I have to write this redundant style instead:

fileset:
  includes: $dirWebapp/**
  excludes: $dirWebapp/**/*.py
  targetDir: $INSTALL_PATH/webIma

What is worst, in the 2nd case, no exclude rule is generated in the generated izpack.xml. It is also quite verbose, listing all the subdirectories.

@DavidPerezIngeniero
Copy link
Author

My 2nd try:

fileset:
  includes: $dirWebapp/**
  regexExcludes: .*\.py
  targetDir: $INSTALL_PATH/webIma

I don't see any exclusion either in the generated izpack.xml. :-(

I think it would have been better, to stick closely to the IzPack spec, as it is more powerful, and easier to implement.

@bmc
Copy link
Owner

bmc commented Jan 29, 2015

Perhaps I should reimplement it to generate the regular IzPack wildcards. Instead, sbt-izpack expands the wildcards itself.

However, I won't be getting to that any time soon, I'm afraid.

In the meantime, please realize what $dirWebapp/** is doing. It's recursing down the entire tree, picking up every single file. That can take time; it's a pretty broad wildcard. A quicker fix might be if I were to allow you to specify a top-level directory ($dirWebapp), with the understanding that doing so means "the entire directory tree". I suspect that would be faster.

@DavidPerezIngeniero
Copy link
Author

Don't worry, this has motivated me to fork for the 1st time in github. When working, I'll make a pull request.

@DavidPerezIngeniero
Copy link
Author

Here is my first forked project in github. I'd like to make a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants