Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parseChallenge erroring out with Digest "charset" set #4

Open
martin-fisher opened this issue Jun 27, 2018 · 1 comment
Open

parseChallenge erroring out with Digest "charset" set #4

martin-fisher opened this issue Jun 27, 2018 · 1 comment

Comments

@martin-fisher
Copy link

If the Digest contains a "charset" directive, (or anything not covered by the switch statement) it will throw a ErrBadChallenge Error. ("Challenge is bad").

One can add the additional cases into the switch to solve this of course, but for anyone wondering why the error appears...
@icholy
Copy link

icholy commented Jun 3, 2020

The RFC states that unrecognised parameters MUST be ignored. This is a bug in the library.

yaazkal added a commit to yaazkal/digest that referenced this issue May 14, 2022
@yaazkal
Fix: Ignore unrecognised parameters
c1c8558 
Related to bobziuchkovski#4
@yaazkal yaazkal mentioned this issue May 14, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@icholy @martin-fisher