Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

개발 규칙 정하기 #1

Open
jo-bata opened this issue Mar 11, 2019 · 0 comments
Open

개발 규칙 정하기 #1

jo-bata opened this issue Mar 11, 2019 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@jo-bata
Copy link

jo-bata commented Mar 11, 2019

개발 규칙 정하기

Description

  • 하단 처럼 개발 규칙을 정해보자

branch 전략

  • git flow를 따른다

branch naming

  • issue number-issue name
  • ex) 16-defining-development-rules

commit message

  • [#issue number>] [behavior(upper case)] message
  • ex. [#16] [FIX] 개발 규칙 오타 수정

개발 프로세스

  1. issue 생성
  2. issue 기반 branch 생성
  3. issue와 관련된 feature 개발 완료
    • 개인별 repo or branch에서는 commit 각자 스타일에 맞춰
  4. merge commit 생성시(PR) commit message rule에 맞춰서 squash merge를 위해 commit history 단장
  5. PR이 주요 branch로 merge되기 위한 조건
    • 최소 1명의 review의 approve
    • CI로 인한 build success
    • test case 작성 - optional
  6. merge 후 feature branch 제거
  7. issue close
@jo-bata jo-bata added the enhancement New feature or request label Mar 11, 2019
@jo-bata jo-bata self-assigned this Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant