refactor: auth 정보 tanstack query를 이용해 관리하기 #302
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
kiuuon
commented
May 1, 2024
Comment on lines
+30
to
+33
| if (authStatusIsPending || myRoomCodeIsPending) { | ||
| // TODO: Add loading page | ||
| return <div>Loading...</div>; | ||
| } |
There was a problem hiding this comment.
처음 접속 시 로그인 여부와 방 참가 여부를 fetch하는 동안 띄울 Loading 페이지가 있으면 좋을거 같습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
유저 정보에서 로그인 여부와, 방 참가 여부(참가 중인 방 코드)가 분리되어서 분리 된 api에 맞게 수정했습니다.
원래 fetch 후 authContext로 유저 정보를 관리하던 것을 tanstack query를 이용해 관리하도록 변경해 주었습니다.
로그인 여부와 방 참가 여부(참가 중인 방 코드)도 tanstack query를 이용해 fetch 해서 서버쪽 상태관리는 모두 tanstack query를 이용해 하도록 했습니다.
authContext 관련 파일들은 모두 삭제했습니다.
Changes Made
Extra Comments
roomProvider의 isHost와 roomCode는 zustand로 이주 관련 pr이 머지되면 이어서 작업하는게 나을거 같아서 일단 Draft pr로 올렸습니다