Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove events #1416

Merged
merged 13 commits into from
Aug 29, 2024
Merged

Remove events #1416

merged 13 commits into from
Aug 29, 2024

Conversation

gonzalojaubert
Copy link
Contributor

Description

Add Remove events action

Changes

See https://github.com/boostercloud/booster/compare/main...Optum:booster:remove_events?expand=1#diff-f29d96b182c51086eeac1a87c2c597dac61b43e1a28fcc4fbe76a51d4c02fec2

Checks

  • Project Builds
  • Project passes tests and checks
  • Updated documentation accordingly

@what-the-diff
Copy link

what-the-diff bot commented Jun 14, 2023

PR Summary

  • Add remove events feature
    This update enables the ability to remove events from the system.

  • Handle deleted and soft-deleted items
    The system now filters out deleted items in various operations and properly updates related read models.

  • Add deletedAt field to responses
    The deletedAt field has been added to EventQueryResponse and EventSearchResponse for better filtering and management of deleted items.

  • Improve search functionality
    Updated search functions now return the deletedAt field if it exists for an item and apply filters based on this field.

  • Update projections with delete event
    Projections have been updated to handle events' deletion and soft-deletion, ensuring that read models are properly maintained.

  • Enhance deletion of events and snapshots
    This update adds support for deleting events and snapshots, keeping the system cleaner and more efficient.

@ghost
Copy link

ghost commented Jun 14, 2023 •
edited by ghost
Loading

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@gonzalogarciajaubert
Copy link
Collaborator

/integration sha=6de83edca2b8eacb05cea86fdf349388a89b299f

@github-actions
Copy link
Contributor

⌛ Integration tests are running...

Check their status here 👈

@github-actions
Copy link
Contributor

❌ Oh no! Integration tests have failed

@github-actions
Copy link
Contributor

⌛ Integration tests are running...

Check their status here 👈

@github-actions
Copy link
Contributor

✅ Integration tests have finished successfully!

@gonzalogarciajaubert gonzalogarciajaubert marked this pull request as draft October 26, 2023 13:51
@gonzalogarciajaubert
Copy link
Collaborator

/integration sha=0a65005

@github-actions GitHub Actions
Copy link
Contributor

⌛ Integration tests are running...

Check their status here 👈

@github-actions GitHub Actions
Copy link
Contributor

✅ Integration tests have finished successfully!

Castro, Mario added 3 commits August 21, 2024 12:33
Merge remote-tracking branch 'origin/main' into remove_events
f032e79 
# Conflicts:
#	common/config/rush/pnpm-lock.yaml
#	packages/framework-core/src/booster-event-processor.ts
#	packages/framework-core/src/booster.ts
#	packages/framework-core/src/decorators/projects.ts
#	packages/framework-core/src/services/read-model-store.ts
#	packages/framework-core/test/services/read-model-store.test.ts
#	packages/framework-provider-aws/src/setup.ts
#	packages/framework-provider-azure/src/index.ts
#	packages/framework-provider-local/src/index.ts
#	packages/framework-types/src/config.ts
#	packages/framework-types/src/provider.ts
Post-merge fixes
0bdbd6e
pnpm-lock.yaml update
eb55ac9
@MarcAstr0
Copy link
Collaborator

/integration sha=eb55ac9f34e6cc017e6c92dcfc0c99e359dcdfb4

@github-actions GitHub Actions
Copy link
Contributor

⌛ Integration tests are running...

Check their status here 👈

@github-actions GitHub Actions
Copy link
Contributor

✅ Integration tests have finished successfully!

@MarcAstr0 MarcAstr0 marked this pull request as ready for review August 27, 2024 15:38
davidverdu
davidverdu reviewed Aug 27, 2024
View reviewed changes
Copy link
Collaborator

@davidverdu davidverdu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally speaking looks good for such a complex feature, congrats. Nonetheless, I left some comments. Let me know when you address them, so that I can do the final review

davidverdu
davidverdu approved these changes Aug 29, 2024
View reviewed changes
Copy link
Collaborator

@davidverdu davidverdu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MarcAstr0 MarcAstr0 merged commit b791d83 into boostercloud:main Aug 29, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcAstr0 MarcAstr0 MarcAstr0 left review comments

@davidverdu davidverdu davidverdu approved these changes

@gonzalogarciajaubert gonzalogarciajaubert Awaiting requested review from gonzalogarciajaubert

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gonzalojaubert @gonzalogarciajaubert @MarcAstr0 @davidverdu