Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Dynamic Properties (getters) with Schema Migrations #1417

Merged
merged 2 commits into from
Jul 18, 2023
Merged

Fix Dynamic Properties (getters) with Schema Migrations #1417

merged 2 commits into from
Jul 18, 2023

Conversation

gonzalojaubert
Copy link
Contributor

No description provided.

@what-the-diff
Copy link

what-the-diff bot commented Jun 14, 2023

PR Summary

  • Change in ReadModelSchemaMigrator class
    Updates the method to create new ReadModel objects by using Object.assign() instead of the spread operator for improved compatibility.

  • Updated mockPropertyName variable in GraphQLQueryGenerator test
    Prefixes the mockPropertyName variable with an underscore for better naming conventions in testing scenarios.

@ghost
Copy link

ghost commented Jun 14, 2023 •
edited by ghost
Loading

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@gonzalogarciajaubert
Copy link
Collaborator

/integration sha=ab3709a

@github-actions
Copy link
Contributor

⌛ Integration tests are running...

Check their status here 👈

@github-actions
Copy link
Contributor

✅ Integration tests have finished successfully!

@gonzalogarciajaubert gonzalogarciajaubert merged commit 82344a9 into boostercloud:main Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvaroloes alvaroloes alvaroloes approved these changes

@charlietfe charlietfe charlietfe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gonzalojaubert @gonzalogarciajaubert @charlietfe @alvaroloes