Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed some redundant code #1426

Merged
merged 1 commit into from
Sep 4, 2023
Merged

Conversation

turnerran
Copy link
Contributor

Made some minor refactoring. Mainly the usage of optional changing for shorter syntax.

@what-the-diff
Copy link

what-the-diff bot commented Sep 1, 2023

PR Summary

  • Update on BoosterChat Component
    Made changes in the BoosterChat.tsx file to improve search functionality and user interface. The component no longer checks whether the query is null before proceeding with the search, making the search functionality smoother. Also, the 'What is Booster Framework?' button has been removed, and the positioning of the remaining buttons has been improved for a cleaner interface.

  • Optimization in Sidebar and Navbar Components
    Unused import statements have been removed and optional chaining operators have been added in CustomSidebarItem.jsx, DocSidebarItem/index.js, and NavbarNavLink.js files. This improves the efficiency of the code, making the sidebar and navigation components faster and smoother.

  • Enhancement in Chat Feature of Navbar
    In the file CustomNavbarItem.tsx, similar to BoosterChat, the search functionality has been improved by removing the condition query === null. Also, a part of the chat feature has been enhanced by replacing one chat response component with another for better user interactions.

@ghost
Copy link

ghost commented Sep 1, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

Copy link
Member

@javiertoledo javiertoledo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!!

@javiertoledo javiertoledo merged commit 9bda21f into boostercloud:main Sep 4, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants