Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dropped ttypescript in favor of ts-patch #1432

Merged
merged 5 commits into from
Oct 8, 2023
Merged

Dropped ttypescript in favor of ts-patch #1432

merged 5 commits into from
Oct 8, 2023

Conversation

javiertoledo
Copy link
Member

Description

This PR drops the use of ttypescript, which has been deprecated, in favor of the more modern library ts-patch.

There have been reports of ttypescript yielding compilation errors in some environments, so this change should also solve them #1429

Checks

  • Project Builds
  • Project passes tests and checks
  • Updated documentation accordingly

@what-the-diff
Copy link

what-the-diff bot commented Sep 24, 2023

PR Summary

  • Updated TypeScript Patch Version
    The 'ts-patch' version has been updated to '2.0.2' for several packages in the project (cli, framework-integration-tests, and metadata-booster). This update aims to enhance TypeScript's hacking ability.

  • Farewell to ttypescript
    Removed 'ttypescript' from the project, specifically from the framework-core and metadata-booster packages. This change simplifies the developmental dependencies.

  • Adjustments to Documentation
    Several updates and tweaks have been made to the documentation. This includes both the metadata-booster README.md file and the data-migrations documentation found on the website. These modifications ensure that the documentation remains relevant and user-friendly.

The PR is designed to keep our tool versions up-to-date and our documentation clean, ultimately leading to a smoother developer experience and better overall performance.

@ghost
Copy link

ghost commented Sep 24, 2023 •
edited by ghost
Loading

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@github-actions
Copy link
Contributor

github-actions bot commented Sep 24, 2023 •
edited
Loading

Oops, looks like you forgot to add a changeset.

⚠️ Please run rush change and commit the changeset file.

This command will prompt you for a change description and generate a changeset file. You can read more about changesets here.

Remember that you should use the version bump that is appropriate for the change you are making:

Version bump Meaning
patch Bug fixes, documentation changes, etc.
minor New features, non-breaking changes
major Breaking changes

If you are unsure about which version bump to use, please ask in the comments and we will help you out.

@javiertoledo
Copy link
Member Author

/integration sha=586e30a0f8315972b3b8c9f6133269a46b1e5b14

@github-actions
Copy link
Contributor

⌛ Integration tests are running...

Check their status here 👈

@github-actions
Copy link
Contributor

❌ Oh no! Integration tests have failed

gonzalogarciajaubert
gonzalogarciajaubert approved these changes Sep 25, 2023
View reviewed changes
Copy link
Collaborator

@gonzalogarciajaubert gonzalogarciajaubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

NickSeagull
NickSeagull approved these changes Sep 25, 2023
View reviewed changes
Copy link
Member

@NickSeagull NickSeagull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooooooh 😍 I'm so excited about this one! Been waiting this for long!!

@javiertoledo javiertoledo force-pushed the upgrade/ts-patch branch 2 times, most recently from ba8b04b to a484dd2 Compare September 27, 2023 15:14
@javiertoledo javiertoledo changed the base branch from main to upgrade/node-18 October 4, 2023 21:19
@javiertoledo
Copy link
Member Author

/integration sha=05908172fad3b740fa93ced78ee34a3fce642a3b

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

⌛ Integration tests are running...

Check their status here 👈

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

❌ Oh no! Integration tests have failed

@javiertoledo
Copy link
Member Author

/integration sha=0aa25e24ba646e824d6fbc2e2701193daa0e73cd

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

⌛ Integration tests are running...

Check their status here 👈

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

❌ Oh no! Integration tests have failed

@javiertoledo javiertoledo mentioned this pull request Oct 8, 2023
Closed
@javiertoledo javiertoledo changed the base branch from upgrade/node-18 to v2.x.x October 8, 2023 10:55
@javiertoledo javiertoledo self-assigned this Oct 8, 2023
@javiertoledo javiertoledo force-pushed the upgrade/ts-patch branch 2 times, most recently from 060636b to c60a8f2 Compare October 8, 2023 12:26
@javiertoledo
Copy link
Member Author

/integration sha=695e2619816807f1a9f91f83c293abe5d19a7da2

@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2023

⌛ Integration tests are running...

Check their status here 👈

@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2023

✅ Integration tests have finished successfully!

@javiertoledo javiertoledo merged commit b606fe0 into v2.x.x Oct 8, 2023
6 checks passed
@javiertoledo javiertoledo deleted the upgrade/ts-patch branch October 8, 2023 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickSeagull NickSeagull NickSeagull approved these changes

@gonzalogarciajaubert gonzalogarciajaubert gonzalogarciajaubert approved these changes

Assignees

@javiertoledo javiertoledo

Labels
maintainance
Projects
Booster Maintainance
Status: Done
Milestone
v2.x.x
Development

Successfully merging this pull request may close these issues.
3 participants
@javiertoledo @gonzalogarciajaubert @NickSeagull