Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade AWS SDK to v3 #1459

Open
javiertoledo opened this issue Oct 8, 2023 · 1 comment
Open

Upgrade AWS SDK to v3 #1459

javiertoledo opened this issue Oct 8, 2023 · 1 comment
Labels
dependencies Pull requests that update a dependency file maintainance provider:aws Related to the AWS cloud provider

Comments

@javiertoledo
Copy link
Member

As we consider upgrading to Node.js runtime v18 in our AWS Lambda environment, there are a couple of notable implications regarding AWS SDK management:

  1. AWS SDK v2 Deployment with Node.js v18:

    • If we opt to retain AWS SDK v2, we'd need to deploy it manually with each Lambda function, as per the AWS announcement.
  2. Upgrading to AWS SDK v3:

    • Alternatively, upgrading to AWS SDK v3 could streamline the deployment process since it comes preloaded with the Node.js v18 runtime. This approach could also potentially simplify the management of AWS SDK within our projects.
  3. Deprecated Types Package Removal:

    • Additionally, the deprecated package ...framework-provider-aws-infrastructure | WARN deprecated @types/[email protected] can likely be removed from our dependencies. According to the npm registry, AWS SDK now provides its own type definitions, rendering this package obsolete.

Originally suggested by @samueldominguez in #1431 (comment)

@javiertoledo javiertoledo added dependencies Pull requests that update a dependency file provider:aws Related to the AWS cloud provider maintainance labels Oct 8, 2023
@javiertoledo javiertoledo removed this from the v2.x.x - Next major version milestone Oct 24, 2023
@javiertoledo
Copy link
Member Author

While the AWS provider has been discontinued (See #1477) due to issues with the AWS CDK, the deployment scripts are still functional, and the library part of the provider is not affected, as it is using the AWS SDK. It would be worth upgrading the AWS integration as this part could be reused if the infrastructure package is rewritten using the CDK v2 or an alternate deployment strategy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file maintainance provider:aws Related to the AWS cloud provider
Projects
Status: No status
Development

No branches or pull requests

1 participant