Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade deprecated packages CLI and framework-types #1485

Merged
merged 3 commits into from
Oct 27, 2023
Merged

Upgrade deprecated packages CLI and framework-types #1485

merged 3 commits into from
Oct 27, 2023

Conversation

santigamo
Copy link
Collaborator

Description

Upgrade deprecated packages CLI and framework-types

Changes

  • @types/[email protected] removed from packages/framework-types:
  • Upgrade oclif to latest stable version
  • Upgrade fancy-test to latest stable version
  • Updated testing assertions due to new oclif error handling

Checks

  • Project Builds
  • Project passes tests and checks
  • Updated documentation accordingly

@santigamo santigamo self-assigned this Oct 27, 2023
@santigamo santigamo requested review from javiertoledo and gonzalogarciajaubert and removed request for javiertoledo October 27, 2023 12:17
@santigamo santigamo linked an issue Oct 27, 2023 that may be closed by this pull request
Review and Upgrade Deprecated Packages #1461
Open
9 tasks
javiertoledo
javiertoledo approved these changes Oct 27, 2023
View reviewed changes
Copy link
Member

@javiertoledo javiertoledo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work here!

@javiertoledo
Copy link
Member

/integration sha=641d0237fd493cf57062b11d2937d96c47563234

@github-actions
Copy link
Contributor

⌛ Integration tests are running...

Check their status here 👈

@javiertoledo javiertoledo mentioned this pull request Oct 27, 2023
Open
9 tasks
@github-actions
Copy link
Contributor

✅ Integration tests have finished successfully!

@javiertoledo javiertoledo merged commit 7e638f6 into v2.x.x Oct 27, 2023
6 checks passed
@javiertoledo javiertoledo deleted the upgrade/package-cli-and-framework-types branch October 27, 2023 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiertoledo javiertoledo javiertoledo approved these changes

@gonzalogarciajaubert gonzalogarciajaubert Awaiting requested review from gonzalogarciajaubert

Assignees

@santigamo santigamo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Review and Upgrade Deprecated Packages
2 participants
@santigamo @javiertoledo