Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed incorrect return type of Searcher.searchOne #1535

Closed

Conversation

sdellysse
Copy link

Description

Changes

Return type of Searcher.searchOne was incorrect, fixed. Also fixed deprecation notice for Searcher.findById pointing to nonexistant function.

Checks

  • Project Builds
  • Project passes tests and checks
  • Updated documentation accordingly

Copy link

what-the-diff bot commented May 24, 2024

PR Summary

  • Update in findById Method of Searcher Class
    The method for searching for specific content in our system, findById, has been refined. We are moving away from the previous method of searcherFunction to a more efficient approach using searchOne.

  • Change in Return Type of searchOne Method
    There's an update to what the searchOne method can potentially return. Apart from existing values, it could now also return undefined, basically indicating that no matching result was found. This enhancement can be beneficial in the event no match is identified, assisting in error handling and providing more precision in search results.

@MarcAstr0 MarcAstr0 mentioned this pull request Jun 11, 2024
3 tasks
@MarcAstr0
Copy link
Collaborator

Closing this PR since changes have been incorporated to PR #1404

@MarcAstr0 MarcAstr0 closed this Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants