Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rocket health sensors #1546

Merged
merged 9 commits into from
Aug 20, 2024
Merged

Conversation

MarcAstr0
Copy link
Collaborator

@MarcAstr0 MarcAstr0 commented Aug 16, 2024

Description

The changes in this PR extend the capabilities introduced in #1421 and add an endpoint for checking the health of the Rockets used by a Booster app deployed to Azure.

Calling this new endpoint will return a result like the following:

[
  {
    "name": "Rockets",
    "id": "rockets",
    "status": "PARTIALLY_UP",
    "components": [
      {
        "name": "rocketsensorsprodurgwebhookfunc",
        "id": "rocketsensorsprodurgwebhookfunc",
        "status": "UP"
      },
      {
        "name": "rocketsensorsprodurgfilesfunc",
        "id": "rocketsensorsprodurgfilesfunc",
        "status": "DOWN"
      }
    ]
  }
]

The main Booster function app will check each Rocket's health by calling its function app URL, which should return a 200 HTTP code if it's up and running.

Changes

  • Modifications to the framework-provider-azure-infrastructure package for adding the Rocket function app names as environment variables to the main Booster function app.
  • Modifications to the framework-provider-azure package for implementing health check requests to the Rocket function apps.
  • Modifications to the framework-core and framework-types packages for adding the new sensor endpoint for Rockets and configuration.
  • Updated docs.

Checks

  • Project Builds
  • Project passes tests and checks
  • Updated documentation accordingly

@MarcAstr0
Copy link
Collaborator Author

/integration sha=6ac2cec5a0d146aed9ff69c1176a6a915efc3256

Copy link

what-the-diff bot commented Aug 16, 2024

PR Summary

  • Added Execution Status Indicator for Rocket Functions
    A new capability called RocketsHealthIndicator was integrated into the default-booster-health-indicators.ts file. Simultaneously, a detailed implementation of how this indicator works was added in a new file called rockets-health-indicator.ts.

  • Examination of Rocket Functions Status
    To ensure the smooth operation of Rocket functions, a system status check function called areRocketFunctionsUp was introduced. The function was integrated into both Azure Provider Library and Local Provider Library for better accessibility and and reliability.

  • functions for identifying Rocket Function app URL and Rocket Function Status
    The rocketFunctionAppUrl function and isRocketFunctionUp function were incorporated into the Azure Library. These new additions enable easier identification of the Rocket Function application URL and allow for efficient checking of Rocket Function's operational status.

  • Updates in Azure Infrastructure
    The project’s Azure Infrastructure package underwent a variety of updates. The terraform-function-app.ts and terraform-function-app-settings.ts files along with the GraphQLFunction and TerraformFunctionApp classes have been improved and updated for better performance.

  • Improved Provider Sensor Library
    The ProviderSensorLibrary interface in the Framework Types package underwent enhancement for better system analysis and project execution.

  • Interface Enhancement
    Lastly, the SensorBoosterHealthConfiguration interface in the Framework Types package was also updated. The improved interface will aid in better system health monitoring and diagnostics.

Copy link
Contributor

⌛ Integration tests are running...

Check their status here 👈

Copy link
Contributor

❌ Oh no! Integration tests have failed

1 similar comment
Copy link
Contributor

❌ Oh no! Integration tests have failed

Copy link
Contributor

⌛ Integration tests are running...

Check their status here 👈

Copy link
Contributor

❌ Oh no! Integration tests have failed

@MarcAstr0
Copy link
Collaborator Author

/integration sha=89abb5de0b448907e9684ea16518068f1efb32b9

Copy link
Contributor

⌛ Integration tests are running...

Check their status here 👈

# Conflicts:
#	common/config/rush/pnpm-lock.yaml
Copy link
Contributor

❌ Oh no! Integration tests have failed

@MarcAstr0
Copy link
Collaborator Author

/integration sha=cf75012030de7b062dda7433a33ea4cf31d5f3a7

Copy link
Contributor

⌛ Integration tests are running...

Check their status here 👈

Copy link
Contributor

✅ Integration tests have finished successfully!

@MarcAstr0 MarcAstr0 added feature-request New feature or request package:core Affects the core package provider:azure Related to the Azure cloud provider package:framework-types labels Aug 19, 2024
@MarcAstr0 MarcAstr0 marked this pull request as ready for review August 19, 2024 20:39
Copy link

@v-gonzalog v-gonzalog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@davidverdu davidverdu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MarcAstr0 MarcAstr0 merged commit cb500c9 into boostercloud:main Aug 20, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request New feature or request package:core Affects the core package package:framework-types provider:azure Related to the Azure cloud provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants