Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node 20 support #1550

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

Node 20 support #1550

wants to merge 9 commits into from

Conversation

MarcAstr0
Copy link
Collaborator

@MarcAstr0 MarcAstr0 commented Sep 11, 2024 •
edited
Loading

Description

Node.js 18 will reach EOL in April 2025.

This PR includes the necessary changes for Booster to run with the latest LTS release of Node.js (20), considering that Azure Functions has a GA support level for Node.js 20.

Changes

  • Update dependencies to work with Node.js 20.
  • Apply small changes to the Azure provider infrastructure package due to changes in the Terraform CDK.
  • Add an upgrade-v3.md doc listing breaking changes when upgrading from 2.x to 3.x.

Checks

  • Project Builds
  • Project passes tests and checks
  • Updated documentation accordingly

@MarcAstr0
Copy link
Collaborator Author

/integration sha=047bf5a353965251172eba59bc5a3fc9e0b71947

@what-the-diff What The Diff
Copy link

what-the-diff bot commented Sep 11, 2024

PR Summary

  • Adding a new support script
    A new file named install-run-rush-pnpm.js has been added to help in the consistent installation of currently used npm package manager.

  • Improving existing scripts
    Scripts install-run-rush.js and install-run-rushx.js have been updated, likely to support the efficient use of project dependencies.

  • Update to project specific package.json files
    Extensive updates have been made across various components of the project including application-tester, cli, framework-common-helpers, framework-core, framework-integration-tests, framework-provider-aws-infrastructure, framework-provider-aws, framework-provider-azure-infrastructure, framework-provider-azure, framework-provider-local-infrastructure, framework-provider-local, framework-types, metadata-booster, and the tools/eslint-config. These changes indicate that package dependencies are updated or modified possibly to keep up with new features and patches provided by those dependencies.

  • Modification in project template & demo
    Updates have been made to project files cli/src/templates/project/package-json.ts, cli/test/fixtures/mock_project/package.json, framework-integration-tests/integration/fixtures/cart-demo/package.json to replicate the new standards and changes in the project components' package.json files.

  • Update on Azure's Gateway infrastructure script
    An update has been made to file framework-provider-azure-infrastructure/src/infrastructure/synth/gateway/terraform-application-gateway.ts, indicating a change in how Azure's gateway infrastructure is managed or utilized.

  • Configuration update
    The rush.json file, which is one of the most project's important configuration files, has been updated. This change hints at an adjustment in project standards or workflows.

  • Website package handling
    Manifest files - website/package-lock.json and website/package.json for the website part of the project have also been updated.

Note: The versions of Node.js specified in the engines field have been upgraded from "node": ">=18.0.0 <19.0.0" to "node": ">=20.0.0 <21.0.0". This is an upgrade to a later version of Node.js, implying better performance and access to new Node.js features.

@github-actions GitHub Actions
Copy link
Contributor

⌛ Integration tests are running...

Check their status here 👈

@github-actions GitHub Actions
Copy link
Contributor

❌ Oh no! Integration tests have failed

@MarcAstr0
Copy link
Collaborator Author

/integration sha=1338b5dba5bf9b755b6ab77494eeb43c832f28e9

@github-actions GitHub Actions
Copy link
Contributor

⌛ Integration tests are running...

Check their status here 👈

@MarcAstr0
Copy link
Collaborator Author

/integration sha=a07e9562ad2be72c4ce58ecc4a2ac57f27f081d2)

@github-actions GitHub Actions
Copy link
Contributor

⌛ Integration tests are running...

Check their status here 👈

@github-actions GitHub Actions
Copy link
Contributor

✅ Integration tests have finished successfully!

@github-actions GitHub Actions
Copy link
Contributor

❌ Oh no! Integration tests have failed

@github-actions GitHub Actions
Copy link
Contributor

⌛ Integration tests are running...

Check their status here 👈

@github-actions GitHub Actions
Copy link
Contributor

❌ Oh no! Integration tests have failed

@MarcAstr0
Copy link
Collaborator Author

/integration sha=a07e9562ad2be72c4ce58ecc4a2ac57f27f081d2

@github-actions GitHub Actions
Copy link
Contributor

⌛ Integration tests are running...

Check their status here 👈

@github-actions GitHub Actions
Copy link
Contributor

❌ Oh no! Integration tests have failed

@MarcAstr0
Copy link
Collaborator Author

/integration sha=ff18868

@github-actions GitHub Actions
Copy link
Contributor

⌛ Integration tests are running...

Check their status here 👈

@github-actions GitHub Actions
Copy link
Contributor

❌ Oh no! Integration tests have failed

@MarcAstr0
Copy link
Collaborator Author

/integration sha=c6a3c42

@github-actions GitHub Actions
Copy link
Contributor

⌛ Integration tests are running...

Check their status here 👈

@github-actions GitHub Actions
Copy link
Contributor

❌ Oh no! Integration tests have failed

@MarcAstr0
Copy link
Collaborator Author

/integration sha=c6a3c42

@github-actions GitHub Actions
Copy link
Contributor

⌛ Integration tests are running...

Check their status here 👈

@github-actions GitHub Actions
Copy link
Contributor

❌ Oh no! Integration tests have failed

@MarcAstr0
Copy link
Collaborator Author

/integration sha=285d512b201258380a6fcb1f2f99d0466ee1fc77

@github-actions GitHub Actions
Copy link
Contributor

⌛ Integration tests are running...

Check their status here 👈

@github-actions GitHub Actions
Copy link
Contributor

❌ Oh no! Integration tests have failed

@MarcAstr0
Copy link
Collaborator Author

/integration sha=9239fd03d6d22929c0d169b4768b8ad24ab81c62

@github-actions GitHub Actions
Copy link
Contributor

⌛ Integration tests are running...

Check their status here 👈

@github-actions GitHub Actions
Copy link
Contributor

✅ Integration tests have finished successfully!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@MarcAstr0