Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PROD env: during catchup many validators did not get enrolled and many blocks were generated with a single validator. #2673

Open
hewison-chris opened this issue Nov 16, 2021 · 4 comments
Open

PROD env: during catchup many validators did not get enrolled and many blocks were generated with a single validator. #2673

hewison-chris opened this issue Nov 16, 2021 · 4 comments
Assignees
@hewison-chris
Labels
C. Block Creation Related to Settlement TestNet (Validator) prio-high Will have an effect in the next three sprints type-bug Things don't work as they were intended to, or the way they were intended to work doesn't make sense
Milestone
6.1 TestNet Phase A

Comments

@hewison-chris
Copy link
Contributor

hewison-chris commented Nov 16, 2021 •
edited
Loading

When not all have signed a block then the missing validators should be shown as 0 in the string. Currently only signed validators are shown with a 1.
For example https://v7.bosagora.io/blocks/4096

"validators":"1"

is incorrect if there are 6 active validators.
It should be something like

"validators":"001000"

The issue is that it was externalizing blocks with only a single validator enrolled.
@hewison-chris hewison-chris self-assigned this Nov 16, 2021
@hewison-chris hewison-chris added C. Block Creation Related to Settlement TestNet (Validator) prio-high Will have an effect in the next three sprints type-bug Things don't work as they were intended to, or the way they were intended to work doesn't make sense labels Nov 16, 2021
@hewison-chris hewison-chris added this to the 5. CoinNet release milestone Nov 16, 2021
@TrustHenry
Copy link
Member

https://v7.bosagora.io/validators?height=4096
There is only one valid validator for that block height.

@hewison-chris
Copy link
Contributor Author

https://v7.bosagora.io/validators?height=4096 There is only one valid validator for that block height.

Then we have a different bug. It should not have externalized a block with only a single validator enrolled.

@hewison-chris hewison-chris changed the title Json returned with rest api for block does not show validators who did not sign PROD env: during catchup many validators did not get enrolled and many blocks were generated with a single validator. Nov 16, 2021
@omerfirmak
Copy link
Contributor

I think this is expected, fbdb62b

@hewison-chris
Copy link
Contributor Author

Not sure this should be hard coded to 1 though. Maybe it should be a consensus param.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hewison-chris hewison-chris

Labels
C. Block Creation Related to Settlement TestNet (Validator) prio-high Will have an effect in the next three sprints type-bug Things don't work as they were intended to, or the way they were intended to work doesn't make sense
Projects
None yet
Milestone
6.1 TestNet Phase A
Development

No branches or pull requests
4 participants
@omerfirmak @hewison-chris @TrustHenry and others