Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the node auto-detect its registry_address #2873

Open
Geod24 opened this issue Jan 18, 2022 · 0 comments
Open

Make the node auto-detect its registry_address #2873

Geod24 opened this issue Jan 18, 2022 · 0 comments
Labels
type-enhancement An improvement of existing functionalities

Comments

@Geod24
Copy link
Collaborator

Geod24 commented Jan 18, 2022

Currently, we have the following configuration item:

// Registry address
public @Optional string registry_address;

As part of the validator config. However, there are a few problems with this:

  • Most nodes will end up needing the registry, not just validators, hence it's in the wrong section;
  • It is currently optional without a default, but it should have a sensible default;
  • A sensible default depends on realm: hence, it could be inferred from realm;
  • (Minor) the name is a bit too verbose;

What we should do is look up the NS records for the realm so that we get the authoritative registries for the realm we want to use. However, there might be a case for overriding the default registry (to avoid a SPOF, reduce load, or improve anonymity), hence we should have the ability to do so. For this, I suggest to turn the single validator.registry_address into node.registries, an array of Address with fuzzy parsing (as in, default to dns:// for scheme if there isn't any).

@Geod24 Geod24 added the type-enhancement An improvement of existing functionalities label Jan 18, 2022
@Geod24 Geod24 added this to the 6. Stabilization milestone Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-enhancement An improvement of existing functionalities
Projects
None yet
Development

No branches or pull requests

2 participants
@Geod24 and others