Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consensus can get stuck in PREPARE phase #3014

Closed
omerfirmak opened this issue Feb 9, 2022 · 4 comments
Closed

Consensus can get stuck in PREPARE phase #3014

omerfirmak opened this issue Feb 9, 2022 · 4 comments
Assignees
Labels
prio-URGENT Affects the current system and need immediate attention type-breaking

Comments

@omerfirmak
Copy link
Contributor

Some nodes fail to commit to a Ballot and we get stuck in PREPARE phase forever. A system wide restart generally unsticks the network.

@omerfirmak omerfirmak added prio-URGENT Affects the current system and need immediate attention type-breaking labels Feb 9, 2022
@omerfirmak omerfirmak added this to the 5. CoinNet release milestone Feb 9, 2022
@hewison-chris
Copy link
Contributor

This could be solved by #3086

@omerfirmak
Copy link
Contributor Author

I will give increasing timeouts a chance. Default implementation returns roundNumber.seconds so we mostly hit the timeout in the first couple of rounds and starting completely over. I am hoping that this would help both with our slow consensus and getting stuck problem.

        milliseconds computeTimeout(uint32_t roundNumber);  // Slot in the vtable

@hewison-chris hewison-chris self-assigned this Feb 22, 2022
@hewison-chris
Copy link
Contributor

hewison-chris commented Feb 22, 2022

But at some point we will still need to timeout and make progress after some kind of automatic reset.
So I think maybe both are needed.

@Geod24
Copy link
Collaborator

Geod24 commented Mar 15, 2022

Should be fixed by #3111

@Geod24 Geod24 closed this as completed Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prio-URGENT Affects the current system and need immediate attention type-breaking
Projects
None yet
Development

No branches or pull requests

3 participants