Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue3158 clean shutdown #3205

Closed

Conversation

hewison-chris
Copy link
Contributor

No description provided.

@hewison-chris hewison-chris self-assigned this Mar 17, 2022
@hewison-chris hewison-chris linked an issue Mar 17, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Mar 22, 2022

Codecov Report

Merging #3205 (fd759a0) into v0.x.x (1ceafbf) will increase coverage by 32.07%.
The diff coverage is 85.33%.

@@             Coverage Diff             @@
##           v0.x.x    #3205       +/-   ##
===========================================
+ Coverage   20.14%   52.21%   +32.07%     
===========================================
  Files          64      371      +307     
  Lines        2879    37768    +34889     
===========================================
+ Hits          580    19722    +19142     
- Misses       2299    18046    +15747     
Flag Coverage Δ
integration 28.53% <78.68%> (+8.38%) ⬆️
unittests 87.33% <85.50%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
source/agora/test/Base.d 80.31% <ø> (ø)
source/agora/test/InvalidBlockSigByzantine.d 96.29% <ø> (ø)
source/agora/node/FullNode.d 75.15% <62.50%> (ø)
source/agora/network/Manager.d 80.59% <75.00%> (ø)
source/agora/node/main.d 46.90% <83.33%> (ø)
source/agora/node/Validator.d 90.95% <85.71%> (ø)
source/agora/consensus/protocol/Nominator.d 91.98% <87.50%> (ø)
source/agora/node/Registry.d 79.95% <100.00%> (ø)
source/agora/test/BlockRewards.d 95.23% <100.00%> (ø)
source/agora/test/PeriodicCatchup.d 96.55% <100.00%> (ø)
... and 323 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1991b1c...fd759a0. Read the comment docs.

@hewison-chris
Copy link
Contributor Author

Closing this as although it is not desirable to have warnings logged when terminating it does not actually cause any problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Control + C does not lead to immediate shutdown
1 participant