fix: parse proxy URI with prepending URL scheme #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parse the URI of the proxy generated from Proxy::new(intercept, proxy_uri) rather than proxy_uri directly, since proxy_uri may be missing a URL scheme and in that case can't be parsed as a URL Signed-off-by: Gavin Inglis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Closes #338
Description of changes:
parse the URI of the proxy generated from Proxy::new(intercept, proxy_uri) rather than proxy_uri directly, since proxy_uri may be missing a URL scheme and in that case can't be parsed as a URL
Testing done:
An aws-k8s-1.31 node with user data
successfully joins the cluster. is the private ipV4 DNS name of an EC2 instance running tinyproxy in the same VPC as the node.
An aws-k8s-1.31 node with user data
and
tinyproxyconfigured to acceptBasicAuth <fake user> <fake password>successfully forwards requests and joins the clusterTerms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.