New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

run_winecommand documentation incorrect #6

Open

domb84 opened this issue Aug 3, 2023 · 0 comments

domb84 commented Aug 3, 2023

Example action in the documentation has "action: wine_winecommand" rather than "action: run_winecommand".

https://maintainers.usebottles.com/installers/structure/Actions#title10

Possible set_registry_key is also incorrect in the dependency documentation. Example is action: set_register_key when the title is set_registry_key.

https://maintainers.usebottles.com/dependencies/structure/Actions#title36#title36

mirkobrombin transferred this issue from bottlesdevs/Bottles

galkinvv added a commit to galkinvv/maintainers-docs that referenced this issue


          fix run_winecommand typo in Actions.md

23659b7

Came to the same issue that was already mentioned in bottlesdevs#6

This correspond to [code](https://github.com/bottlesdevs/Bottles/blob/158fac515cfd34c3ea0768a9800a9b8facbd665a/bottles/backend/managers/installer.py#L169C37-L169C52) and was tested locally with custom installer

galkinvv mentioned this issue

fix run_winecommand typo in Actions.md #7

Merged

galkinvv added a commit to galkinvv/maintainers-docs that referenced this issue


          fix title typo in dependencies Actions.md

18a20f9

It is named as `set_register_key` - see [implemenataion](https://github.com/bottlesdevs/Bottles/blob/158fac515cfd34c3ea0768a9800a9b8facbd665a/bottles/backend/managers/dependency.py#L257)

I did not test it, but this only a title change (just fixing 2nd issue  from bottlesdevs#6 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment