Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Damla, Ceylin] Fix Web Search & Minor Errors & Refactoring #258

Open
4 tasks done
damlakayikci opened this issue Nov 11, 2024 · 6 comments
Open
4 tasks done

[Damla, Ceylin] Fix Web Search & Minor Errors & Refactoring #258

damlakayikci opened this issue Nov 11, 2024 · 6 comments
Assignees

Comments

@damlakayikci
Copy link
Contributor

damlakayikci commented Nov 11, 2024

The web search bar doesn't function as desired and there are some other errors.

  • The search bar doesn't show the text typed.
  • Searching doesn't function.
  • The questions on feed page are static.
  • Some parts of the page (nav bar, side bars) must be consolidated into a single file to avoid duplicate code.

Tasks

  • Add functionality to search bar
  • Create PageComponents.js and move the necessary parts here
  • Pull questions from the database
  • Redirect search results to the corresponding language page.

Deadline: 17.11.24
Estimated effort: 10 hours
Reviewer: @serhan-cakmak @ErayEroglu

@damlakayikci
Copy link
Contributor Author

Hey, I finished PageComponents.js. Would love to hear your feedback about it! There is still some duplicate code between Feed.js and SearchResult.js but do you think I should also move the functions that are used in the navbar to somewhere else?

@ceylingebes
Copy link
Contributor

PageComponents.js looks cool. I think we should also move the duplicated functions to the PageComponents since we can use navbar in upcoming pages such as profile

@ceylingebes
Copy link
Contributor

Also I think we completed task #4 -redirecting search results- as well, aren't we? I checked it but feel free to uncheck it if I'm wrong Damla. Nice work

@Mutti499
Copy link
Contributor

Okay seems like a dope front end! However, I'm starting to feel like I'm hindering your efforts by changing URLs and views completely. Can we talk about them tomorrow? Because we will have to make one more update after them I guess. Maybe I am missing and there are no problems but I have anxiety.. UPSIE.

@ceylingebes
Copy link
Contributor

After loong conversations, we have updated all urls according to the new version of the backend therefore we are ready for a review @serhan-cakmak @ErayEroglu can you check if everything is ok?

@serhan-cakmak
Copy link
Contributor

if you think your work is ready, please create a pr accordingly so that we can merge it to the main. Please also add mutti to the reviewers since he merged some part of this code to his branch already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants