-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Damla, Ceylin] Fix Web Search & Minor Errors & Refactoring #258
Comments
Hey, I finished PageComponents.js. Would love to hear your feedback about it! There is still some duplicate code between Feed.js and SearchResult.js but do you think I should also move the functions that are used in the navbar to somewhere else? |
PageComponents.js looks cool. I think we should also move the duplicated functions to the PageComponents since we can use navbar in upcoming pages such as profile |
Also I think we completed task #4 -redirecting search results- as well, aren't we? I checked it but feel free to uncheck it if I'm wrong Damla. Nice work |
Okay seems like a dope front end! However, I'm starting to feel like I'm hindering your efforts by changing URLs and views completely. Can we talk about them tomorrow? Because we will have to make one more update after them I guess. Maybe I am missing and there are no problems but I have anxiety.. UPSIE. |
After loong conversations, we have updated all urls according to the new version of the backend therefore we are ready for a review @serhan-cakmak @ErayEroglu can you check if everything is ok? |
if you think your work is ready, please create a pr accordingly so that we can merge it to the main. Please also add mutti to the reviewers since he merged some part of this code to his branch already. |
The web search bar doesn't function as desired and there are some other errors.
Tasks
Deadline: 17.11.24
Estimated effort: 10 hours
Reviewer: @serhan-cakmak @ErayEroglu
The text was updated successfully, but these errors were encountered: