Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tap release not working correctly #2

Closed
theofidry opened this issue Nov 15, 2018 · 5 comments
Closed

Tap release not working correctly #2

theofidry opened this issue Nov 15, 2018 · 5 comments

Comments

@theofidry
Copy link
Member

Although new releases are being tagged and PHARs published it doesn't look like the Tap release is updating this repository.

Could this be due to the published artefact being uploaded after the tag?

Any idea @pierredup?
@pierredup
Copy link
Contributor

Looking at the code for tap-release, it tries to get the artefact immediately when a tag is created. So uploading the artefact afterwards indeed won't trigger the update.

@theofidry
Copy link
Member Author

is there anyway to fix that? I doubt I can change the workflow on Box side, maybe there is a hook we could trigger for tap-release

@theofidry
Copy link
Member Author

Opened toolmantim/tap-release#67

@KEINOS
Copy link
Contributor

KEINOS commented May 2, 2019 •
edited
Loading

Sorry, I didn't notice this issue and did a manual update PR #3 to the latest version ...

Nothing better than automated. Please drop the PR #3 if any plan to update after fixing this issue.

@KEINOS KEINOS mentioned this issue May 2, 2019
Merged
@theofidry
Copy link
Member Author

The homebrew tap should now be updated automatically

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pierredup @theofidry @KEINOS