Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When previewing lots of Box Files on same web page, the webpage will jump up and down #365

Open
hxwhou opened this issue Sep 5, 2017 · 2 comments
Labels

Comments

@hxwhou
Copy link

hxwhou commented Sep 5, 2017

Please fill out the following template so we can reproduce and fix your issue as quickly as possible!

Environment:

  • Preview version:1.7.0
  • Browser name and version:chrome and firefox
  • Operating system and version: Mac OS 10.11.6

Steps to reproduce the problem:

  1. preview lots of box files on same webpage
  2. Programmtically focus on the viewer after it loads
// Programmtically focus on the viewer after it loads
 if (this.viewer && this.viewer.containerEl) {
        this.viewer.containerEl.focus();
 }
  1. I am not sure whether it is a good experience in this situation, because it will make the screen jump

What is the expected behavior? (Screenshots can be helpful here)
I don't want to focus on the viewer after it loads, so could you please
provide a method or param to prevent focus automatically in source code.

What went wrong? (Screenshots can be helpful here)
image
image
image

Link to application or sample code:

If relevant, link to file (or attach file here):

@hxwhou hxwhou changed the title When previewing lots of Box Files on same web page the bowser will jump up and down When previewing lots of Box Files on same web page, the webpage will jump up and down Sep 5, 2017
@tonyjin
Copy link
Contributor

tonyjin commented Sep 6, 2017

Thanks for the report! We'll take a look.

@tonyjin tonyjin added the bug label Sep 12, 2017
@hxwhou
Copy link
Author

hxwhou commented Sep 14, 2017

Auto focus is a good feature when there is only one preview container. But when a lots of preview container on the same web page, it looks not good. So maybe provide a parameter to control whether to focus or not is a good idea. Looking froward to next release this bug will be fixed.
Many thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants