Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create auth test suite that is run for all auth subclasses #216

Open
jmoldow opened this issue Jul 26, 2017 · 0 comments
Open

Create auth test suite that is run for all auth subclasses #216

jmoldow opened this issue Jul 26, 2017 · 0 comments
Assignees

Comments

@jmoldow
Copy link
Contributor

jmoldow commented Jul 26, 2017

#197 was able to occur because we didn't test that JWTAuth.refresh() followed the same rules as OAuth2.refresh(). There is an OAuth2 test case for the scenario that triggered #197, but not a JWTAuth test case for the same scenario.

We should have a common test suite that can be used to test the common interface of all auth subclass. And then make sure we run that suite for all of the subclasses defined in this project.

@jmoldow jmoldow added this to the v2.0.0 Major version bump milestone Jul 26, 2017
@jmoldow jmoldow self-assigned this Jul 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant