Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API change brainstorming #53

Open
thomasballinger opened this issue Nov 25, 2014 · 2 comments
Open

API change brainstorming #53

thomasballinger opened this issue Nov 25, 2014 · 2 comments

Comments

@thomasballinger
Copy link
Member

Rename classes:

  • FmtStr -> FormattedString? AttributedString? ColoredString?
  • FSArray -> Grid? ColoredGrid? FormattedGrid?
  • input.scheduled_event_trigger is bad

Stop using coroutine analogy for Input if it's never used like that

FmtStr init is terrible, make it useful to the user

Window.keep_last_line is incorrectly names, should be keep_cursor_line

num_rows and num_columns are terrible names for the FSArray init!
@thomasballinger thomasballinger changed the title API changes API changes brainstorming Nov 4, 2015
@thomasballinger thomasballinger changed the title API changes brainstorming API change brainstorming Nov 4, 2015
@thomasballinger
Copy link
Member Author

  • Don't allow use Curtsies names or plain bytes for keys

@thomasballinger
Copy link
Member Author

  • Python magic methods should reference normal methods with descriptive names - see __getitem__ and __setitem__ on FmtStr and FSArray.

@thomasballinger thomasballinger mentioned this issue Nov 4, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@thomasballinger