Where nightOrder is called?

[MRegnard]

Hi again!

I recently edited a bit the function player.js/nightOrder, changing a little the signature (nightOrder({ players, fabled, otherroles }) instead of nightOrder({ players, fabled })).
So, and that's normal, the code doesn't work anymore, since the function is called with the wrong number of arguments.

But so, I didn't find it: where this function is called?

Thanks for answer

[bra1n]

The nightOrder function is a VueX Getter, which receives the state property as the first parameter and from there extracts the players and fabled properties. If you want to have any other destructured parameters, you need to add them to state first. (and implement their function)

[MRegnard]

For the different names, it is just because I renamed the variable in the meanwhile. Now, the property is called "other" also in the nightOrder's signature.
But I still don't understand the issue. I indeed forgot to specify this in my previous comment, but, if you're talking about it as I think, I changed the line 11 in players.js

const state = () => ({
  players: [],
  fabled: [],
  bluffs: [],
  other: []
});

Is there another file to change, in more than player.js?

[bra1n]

Then I don't understand what the problem seems to be?
The code you provided looks correct to me.

[MRegnard]

That's strange...
Maybe I have to edit the print? Well, anyway, I have to change it, even if it doesn't solve the issue. Where the night order is printed, I didn't find it?

EDIT: Oh, I just find the bug, but I have no idea why it makes it.

I changed the end of the function:

players.forEach(player => {
      const first = Math.max(firstNight.indexOf(player.role.firstNight), 0);
      const other = Math.max(otherNight.indexOf(player.role.otherNight), 0);
      nightOrder.set(player, { first, other });
    });

Because I already use a variable called "other", I changed the name of variables here:

players.forEach(player => {
      const firstN = Math.max(firstNight.indexOf(player.role.firstNight), 0);
      const otherN = Math.max(otherNight.indexOf(player.role.otherNight), 0);
      nightOrder.set(player, { firstN, otherN });
    });

And, because I tried a version with only nightOrder({ players, fabled }), I know the issue is here: when I use first and other, it works. When I use firstN and otherN, it doesn't.

I suppose these variables are declared somewhere else, so, where is it?

[bra1n]

Ah yeah, that seems to be a duplicate variable then. I'd suggest using an IDE for development work like this, because then you'll get a warning immediately as you write the code. ;-)