How to send a nomination

[MRegnard]

Hi!

I am creating code for special votes, and I just noticed a big issue.
I created a file called src\components\modals\SpecialVoteModal (I insist, it is not directly in components, but in modals).
In this file, I have this:

launchVote(nomination) {
  this.$store.commit("session/nomination", { nomination });
  this.$store.commit("toggleModal", "specialVote");
},

And now, I have my special nomination which works perfectly, but only for the Story Teller. This change wasn't updated for players, like if the file socket.js didn't detected the update of nomination.

So, what I must add to send this nomination to all players? Is it the way to call this function from one folder up? Or must I manually add a command?
Thanks in advance!

[bra1n]

Hey,
the nomination network communication is triggered here: https://github.com/bra1n/townsquare/blob/develop/src/store/socket.js#L862
which calls this method:
https://github.com/bra1n/townsquare/blob/develop/src/store/socket.js#L677
That method sends the nomination data through the websocket, which is then received and handled by all players here:
https://github.com/bra1n/townsquare/blob/develop/src/store/socket.js#L148

[MRegnard]

Well, that's what I thought, but then I don't understand the issue.

Hey, the nomination network communication is triggered here: https://github.com/bra1n/townsquare/blob/develop/src/store/socket.js#L862

As I said, it seems that "the file socket.js didn't detect the update of nomination". So the nomination network is not triggered at all, that's my issue, and I don't understand why.

To write my code, I inspired from nominatePlayer in TownSquare.vue, which looks like:

nominatePlayer(from, to) {
  if (this.session.isSpectator || this.session.lockedVote) return;
    if (to === undefined) {
      this.cancel();
      if (from !== this.nominate) {
        this.nominate = from;
      }
    } else {
      const nomination = [this.nominate, this.players.indexOf(to)];
      this.$store.commit("session/nomination", { nomination });
      this.cancel();
  }
},

If I understood correctly, most of this function is just various checking to see the nomination is correct. So, if I have already a nomination in the format [from, to], I can just write

launchVote(nomination) {
  this.$store.commit("session/nomination", { nomination });
  this.$store.commit("toggleModal", "specialVote");
},

But, in both cases, I don't see when the function used in socket.js is called.

So I have a theory, tell me if this is possible. I think that you never call any function from socket.js. I think that the socket detects automatically any $store.commit and applies the corresponding switch/case. But I think that, because my file is in src\components\modals instead of being directly in src\components, then socket.js doesn't detect this.
This explains why the nomination works from ST's point of view but not from players' point of view.

And so, this is my point, is there a way to call the switch/case in socket.js anyway?
Thanks in advance

[bra1n]

So, the socket.js subscribes to all VueX commit calls and then filters out the relevant ones, meaning if you run this.$store.commit(...), the socket.js will see that and act accordingly, if it matches one of the filtered names. Meaning your code should work, or at least reach the block here: https://github.com/bra1n/townsquare/blob/develop/src/store/socket.js#L862
I'd suggest adding a few console.logs to your code to see exactly what happens when you run this.$store.commit("session/nomination", { nomination });...

[MRegnard]

Oh! Forget everything I said, the issue wasn't where I thought.
I explain: with the special votes, the variable "nomination" doesn't contain 2 numbers. This variable can be [String, Number], [Number, String] or [Number, Table of String].
Obviously, I tried to correct some files, such as the nomination can be run anyway. But, after some tests, I am sure: I forgot some of needed changes, and that's why it didn't work!

So, maybe you can help me now. I edited the files:

• Vote.vue (to correct the printed message and handle the clock)
• Player.vue (only for the function voteLocked)
• TownInfo.vue (not directly linked to this issue, it is to add a skull if the ST is ready to die)
• session.js (for addHistory).

So, here you can enlighten me. With all these files, I correctly adapted the vote for the Story Teller. Now, it seems I forgot again some files, which use the variable "nomination", and so which must be adapted. Do you have any idea of which file I must edit? And so, big hint for find it: this file is (very) probably used only by players, and not by the Story Teller.

[bra1n]

You will probably also need to update the socket.js to account for the new nomination data structure: https://github.com/bra1n/townsquare/blob/develop/src/store/socket.js#L677
And then how the data sent through the socket is handled on the player side here:
https://github.com/bra1n/townsquare/blob/develop/src/store/socket.js#L157

[MRegnard]

Cool!
That's exactly what I was missing!
Thanks a lot!