Skip to content
This repository has been archived by the owner on May 12, 2020. It is now read-only.

add MYS to ABPindo #229

Open
gmarcher opened this issue Dec 6, 2019 · 6 comments
Open

add MYS to ABPindo #229

gmarcher opened this issue Dec 6, 2019 · 6 comments

Comments

@gmarcher
Copy link

gmarcher commented Dec 6, 2019

ABPindo merupakan filter tambahan untuk melengkapi EasyList memblokir iklan mengganggu di situs berbahasa Indonesia dan Malaysia.
form: https://github.com/ABPindo/indonesianadblockrules

ABPindo cover both indonesian and malay region site, so please add MYS code for ABPindo
IDN, MYS: ABPindo

@pes10k
Copy link
Collaborator

pes10k commented Dec 6, 2019

@ryanbr what do you think?

@ryanbr
Copy link

ryanbr commented Dec 7, 2019

Looks pretty clean, a few redundancys from Easylist. https://pastebin.com/EbZjESia but otherwise, looks like a decent list.

@pes10k
Copy link
Collaborator

pes10k commented Dec 7, 2019

Cool you do the following then?

  1. See how it compares to the list we're using currently (https://raw.githubusercontent.com/heradhis/indonesianadblockrules/master/subscriptions/abpindo.txt) and see which seems better / its a good idea to switch
  2. If the new list looks better, open any issues with them to remove redundancies and otherwise clena things up
  3. Make a PR against brave/adblock-rust to change the list in the rust code

(if you'd like any help with #3, happy to help there too)

@ryanbr
Copy link

ryanbr commented Dec 7, 2019

@gmarcher
Copy link
Author

gmarcher commented Dec 7, 2019

1. See how it compares to the list we're using currently (https://raw.githubusercontent.com/heradhis/indonesianadblockrules/master/subscriptions/abpindo.txt) and see which seems better / its a good idea to switch

we are one team/organization
https://raw.githubusercontent.com/heradhis/indonesianadblockrules/master/subscriptions/abpindo.txt
and
https://raw.githubusercontent.com/ABPindo/indonesianadblockrules/master/subscriptions/abpindo.txt (currently main)

gmarcher added a commit to ABPindo/indonesianadblockrules that referenced this issue Dec 7, 2019
@gmarcher
Copy link
Author

gmarcher commented Dec 7, 2019

Looks pretty clean, a few redundancys from Easylist. https://pastebin.com/EbZjESia but otherwise, looks like a decent list.

thanks for your pointer, remove some duplicate done, but not all because we need it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants