From fba0490bc9d898766f5baa5f3cf9dbdc359afb41 Mon Sep 17 00:00:00 2001
From: Andrea <ab.gh@pompel.me>
Date: Mon, 24 Jun 2024 13:35:42 +0200
Subject: [PATCH] brave-missing-break-in-switch.yaml: add
 NOTREACHED_IN_MIGRATION case

---
 .../client/brave-missing-break-in-switch.yaml              | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/assets/semgrep_rules/client/brave-missing-break-in-switch.yaml b/assets/semgrep_rules/client/brave-missing-break-in-switch.yaml
index 3b90e5fb..ac09988b 100644
--- a/assets/semgrep_rules/client/brave-missing-break-in-switch.yaml
+++ b/assets/semgrep_rules/client/brave-missing-break-in-switch.yaml
@@ -9,7 +9,7 @@ rules:
         - https://github.com/struct/mms
         - https://github.com/returntocorp/semgrep/issues/4939
       confidence: MEDIUM
-      source: https://github.com/brave/security-action/blob/main/assets/semgrep_rules/client/missing-break-in-switch.yaml
+      source: https://github.com/brave/security-action/blob/main/assets/semgrep_rules/client/brave-missing-break-in-switch.yaml
       # NOTE: we should also check for default blocks that miss the
       # break/return/exit or equivalent statement/function call.
     message: >-
@@ -50,5 +50,10 @@ rules:
           switch ($VAR) { case $VAL1: NOTREACHED_NORETURN(); case $VAL2: ... }
       - pattern-not: |
           switch ($VAR) { case $VAL1: ... NOTREACHED_NORETURN(); case $VAL2: ... }
+      # NOTREACHED_IN_MIGRATION
+      - pattern-not: |
+          switch ($VAR) { case $VAL1: NOTREACHED_IN_MIGRATION(); case $VAL2: ... }
+      - pattern-not: |
+          switch ($VAR) { case $VAL1: ... NOTREACHED_IN_MIGRATION(); case $VAL2: ... }
       # [[fallthrough]];
       - pattern-not-regex: '\[\[fallthrough\]\];'